Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move width and height mapping to aspect ratio to HTML data #6918

Merged
merged 6 commits into from
Oct 29, 2020

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Oct 14, 2020

The data about some HTML elements' width and height attributes mapping to that element's aspect ratio is in in the wrong place. This PR fixes this problem (and fixes #6786) by:

  • Changing the description of the misplaced aspect-ratio subfeature to describe the attributes' relationship
  • Renames the subfeature to aspect_ratio_computed_from_attributes
  • Mirrors data to complete the Opera and Firefox data
  • Moves the data to the HTML elements

Related to #6903.

@ddbeck ddbeck requested a review from rachelandrew October 14, 2020 13:37
@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Oct 14, 2020
@ddbeck
Copy link
Collaborator Author

ddbeck commented Oct 28, 2020

@rachelandrew could I get your review on this? If it's OK, then merging this will create the fix needed to make the tests pass for for your PR #6903.

Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ddbeck ddbeck merged commit 9dda22b into mdn:master Oct 29, 2020
@ddbeck ddbeck deleted the move-aspect-ratio-data branch October 29, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving or copying internal aspect-ratio data
2 participants