Navigator/vibrate - Firefox for Android doesn't vibrate

[VoxelPrismatic]

A checklist to help your pull request get merged faster:

• Summarize your changes
• Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
• Data: if you tested something, describe how you tested with details like browser and version
• Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
• Link to related issues or pull requests, if any

Summary: Firefox for Android [Daylight, Nightly, Beta] doesn't support vibration, although it always returns true when the window is active
Data: Tested on Firefox for Android Daylight, Nightly and Beta on a Galaxy S8 running Android 9. Test it out with this tool
Notes: I tested that same tool out in Samsung Internet, vibration works fine. I also have mozVibrate() on that tool just in case.

Possible help: Is there a separate note for API/Vibration_API or is it linked? Otherwise all is good

[saschanaz]

There is a bug for this: mozilla-mobile/fenix#2371

[VoxelPrismatic]

I didn't catch that one, thank you.

[saschanaz]

Oops, we need this PR because it really is a known issue! If this has been broken for a while we should document it here.

[VoxelPrismatic]

well then

[ddbeck]

Wow, the existing data here is kinda messy! I think the gist here is that vibration was (inadvertently?) removed in Firefox 72. Check out https://bugzilla.mozilla.org/show_bug.cgi?id=1591113 for details. I think this means we need to restructure the data for both the "firefox" entry and "firefox_android".

It should look a little something like this (ignoring the prefixed entry after these):

  {
    "version_added": "72",
    "partial_implementation": true,
    "notes": "Vibration is disabled. If the window is visible, then <code>navigator.vibrate()</code> returns <code>true</code>, but no vibration takes place (regardless of hardware support). See <a href='https://bugzil.la/1591113'>bug 1591113</code>."
  },
  {
    "version_added": "16",
    "version_removed": "72",
    "notes": [
      "Until Firefox 26 included, when the vibration pattern was too long or any of its elements too large, Firefox threw an exception instead of returning <code>false</code> (<a href='https://bugzil.la/884935'>bug 884935</a>).",
      "From Firefox 32 onwards, when the vibration pattern is too long or any of its elements too large, it returns <code>true</code> but truncates the pattern (<a href='https://bugzil.la/1014581'>bug 1014581</a>).",
    ]
  }

[VoxelPrismatic]

I dont think we should put it on firefox because as far as i know, no desktop or laptop actually has a vibration motor. Adding that info would be redundant.

[VoxelPrismatic]

strange, the build is failing because firefox version 72 is invalid even though the latest firefox daylight is 82.1.3

[ddbeck]

Oops, that was an oversight on my part. Firefox for Android had a discontinuity—it jumped from 68 to 79. So that value should be bumped to 79. Sorry about that!

[ddbeck]

@VoxelPrismatic do you plan to return this PR? Or should we open a follow up issue instead? Either way, thank you!

[VoxelPrismatic]

Oh sorry I didn't receive any emails on this thread.

[VoxelPrismatic]

Just tested on Nightly 210125 17:01 [latest as of writing], still doesn't vibrate

[ddbeck]

Thank you for persisting at this, @VoxelPrismatic! A couple of suggestions here. We're quite close, but it's unusual data.

[ddbeck]

Thank you! 🎉

Stale