From 5fb471fd8a18517cde1809084fb1384684695cb9 Mon Sep 17 00:00:00 2001 From: "Michael[tm] Smith" Date: Sun, 13 Dec 2020 12:52:30 +0900 Subject: [PATCH 1/2] =?UTF-8?q?PaymentRequest.p.paymentAddress=20=E2=86=92?= =?UTF-8?q?=20shippingAddress?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change renames the BCD paymentAddress subfeature of the PaymentRequest feature to shippingAddress. As noted in https://github.com/mdn/browser-compat-data/issues/7668, it’s been PaymentRequest.prototype.shippingAddress “for years, probably from the start”. Fixes https://github.com/mdn/browser-compat-data/issues/7668 --- api/PaymentRequest.json | 50 ++++++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/api/PaymentRequest.json b/api/PaymentRequest.json index 9edb38e10b46c7..9bbab4bbd43be8 100644 --- a/api/PaymentRequest.json +++ b/api/PaymentRequest.json @@ -503,35 +503,36 @@ } } }, - "paymentAddress": { + "paymentmethodchange_event": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentRequest/paymentAddress", + "mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentRequest/paymentmethodchange_event", + "description": "paymentmethodchange event", "support": { "chrome": { - "version_added": "61" + "version_added": false }, "chrome_android": { - "version_added": "53" + "version_added": false }, "edge": { - "version_added": "15" + "version_added": false }, "firefox": { "version_added": false, - "notes": "Available only in nightly builds as shippingAddress." + "notes": "Available only in nightly builds." }, "firefox_android": { "version_added": false, - "notes": "Available only in nightly builds as shippingAddress." + "notes": "Available only in nightly builds." }, "ie": { "version_added": false }, "opera": { - "version_added": "47" + "version_added": false }, "opera_android": { - "version_added": "44" + "version_added": false }, "safari": { "version_added": null @@ -540,7 +541,7 @@ "version_added": null }, "samsunginternet_android": { - "version_added": "6.0" + "version_added": false }, "webview_android": { "version_added": false @@ -553,10 +554,9 @@ } } }, - "paymentmethodchange_event": { + "requestId": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentRequest/paymentmethodchange_event", - "description": "paymentmethodchange event", + "mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentRequest/requestId", "support": { "chrome": { "version_added": false @@ -565,7 +565,8 @@ "version_added": false }, "edge": { - "version_added": false + "version_added": "≤18", + "version_removed": "79" }, "firefox": { "version_added": false, @@ -604,36 +605,35 @@ } } }, - "requestId": { + "shippingAddress": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentRequest/requestId", + "mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentRequest/shippingAddress", "support": { "chrome": { - "version_added": false + "version_added": "61" }, "chrome_android": { - "version_added": false + "version_added": "53" }, "edge": { - "version_added": "≤18", - "version_removed": "79" + "version_added": "15" }, "firefox": { "version_added": false, - "notes": "Available only in nightly builds." + "notes": "Available only in nightly builds as shippingAddress." }, "firefox_android": { "version_added": false, - "notes": "Available only in nightly builds." + "notes": "Available only in nightly builds as shippingAddress." }, "ie": { "version_added": false }, "opera": { - "version_added": false + "version_added": "47" }, "opera_android": { - "version_added": false + "version_added": "44" }, "safari": { "version_added": null @@ -642,7 +642,7 @@ "version_added": null }, "samsunginternet_android": { - "version_added": false + "version_added": "6.0" }, "webview_android": { "version_added": false From e4c2dabf5d8fadf6b0d024dbf0a08276092aeaf9 Mon Sep 17 00:00:00 2001 From: "Michael[tm] Smith" Date: Mon, 14 Dec 2020 10:21:19 +0900 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Kagami Sascha Rosylight --- api/PaymentRequest.json | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/api/PaymentRequest.json b/api/PaymentRequest.json index 9bbab4bbd43be8..4e5d40c2766942 100644 --- a/api/PaymentRequest.json +++ b/api/PaymentRequest.json @@ -620,11 +620,15 @@ }, "firefox": { "version_added": false, - "notes": "Available only in nightly builds as shippingAddress." + "flags": [ + { + "type": "preference", + "name": "dom.payments.request.enabled" + } + ] }, "firefox_android": { - "version_added": false, - "notes": "Available only in nightly builds as shippingAddress." + "version_added": false }, "ie": { "version_added": false