Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant global attribute 'dropzone' #8095

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 21, 2020

Not in any standard and not implemented anywhere anymore for a long time.

I'll open an mdn/content PR that deletes the sparingly existing content, too.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Dec 21, 2020
Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this was dropped from Chrome in version 59 in 2017, and the last version the other engine that supported it (legacy Edge) was released in October 2018, this seems to meet the criterion in https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#removal-of-irrelevant-features of “a feature was implemented and has since been removed from all browsers dating back two or more years ago”

@sideshowbarker
Copy link
Member

I’m not pushing the merge button yet because it seems best to have at least one other reviewer also OK this one — preferably @ddbeck

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me too. Thank you! 🎉

@ddbeck ddbeck merged commit c409b92 into mdn:master Dec 21, 2020
@Elchi3 Elchi3 deleted the rm-html-dropzone branch December 21, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants