-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add worker_support info for CacheStorage #8783
Conversation
@ddbeck Further, looking at Cache (which is used with That's a bit confusing. It kind of indicates to me that perhaps the note for CacheStorage is incorrect "Accessible from Thoughts? |
My first (possibly wrong!) impressions:
|
@ddbeck Thanks very much. So I have updated in line with your comments and my interpretation. Essentially that CacheStorage was supported in Chrome in service workers from 40, and other workers/main thread from version 43. This is heavily implied by the |
PS For Cache the BCD currently says we have So propose for
Make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I'm really happy with this. I think it's telling a much clearer story! And the proposal for Cache makes sense. I think we just need one more pass on this. Suggestions in line comments.
Co-authored-by: Daniel D. Beck <[email protected]>
Hi @ddbeck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @hamishwillee! 🎉
…icture * upstream/master: (1123 commits) Remove Chromium 89 from String.at / Array.at / TypedArray.at (mdn#8869) Add worker_support info for CacheStorage (mdn#8783) Remove several needless "Enabled by default" notes (mdn#8899) Add HTML global attribute nonce (mdn#8764) api.Navigator.vibrate - Firefox for Android doesn't vibrate (mdn#7172) Mark MediaSource's onsourceclose as not supported in Firefox (mdn#8881) Update Florian's ownership (mdn#8893) Mention fix for Chrome's broken PDF loading (mdn#8867) Fill out Chrome data for html.elements.source.{sizes,srcset} (mdn#8889) Weekly data release for 2021-01-28 Add text-decoration-thickness for Opera 73+ (mdn#8872) Update :is and :where pseudo-classes for Chrome (mdn#7375) Add note re Safari <9 partial srcset/sizes support (mdn#7353) Update data for when href (not xlink:href) can be used in SVG (mdn#6603) Add top-level await (mdn#8807) TouchList: Add Safari Desktop and Safari iOS versions (mdn#8848) Update Firefox versions to account for Firefox 85 release (mdn#8864) Fix page_action.show_matches support for Android (mdn#8844) Update Safari support for devicechange_event (mdn#8863) Add HTTPS-only to privacy.network (mdn#8830) ...
A win! Thanks @ddbeck |
CacheStorage is defined in the service worker spec but also works in the main thread and other worker types. This PR updates CacheStorage information to have a
worker_support
key.What I did was duplicate the top level support for
CacheStorage
as the keyworker_support
. My assumption being that worker support went in for the first version unless otherwise documented (seems reasonable because this is in the service worker spec)There is a note indicating that for Chrome it became accessible through WorkerWindowScope (and window) in version 43. My assumption is therefore that this is a case where the class was available, but inaccessible. So I have updated the worker support information to 43 for that case.
There is also a note for FF on all methods: "notes": "Extended Support Releases (ESR) before Firefox 78 ESR do not support service workers and the Push API.". I copied this to just mention service workers.
@ddbeck