Update Safari support for devicechange_event #8863
Conversation
Per work done by @ddbeck [1], support begins with version 11, aligning with support for `ondevicechange`. [1] mdn#8688 (comment)
github-actions
bot
added
the
data:api
There was a problem hiding this comment.
Thanks, @Lytigas! I appreciate the extra research you did here. I'm not quite sure what the full story is here, to be honest. The Safari releases are a bit opaque. It's my understanding that it's possible for the WebKit tag to be off or for features to be backported in ways that don't show in changesets (e.g., toggling build flags or flipping default settings). So perhaps the feature existed in 11 and changed in 11.1 and that's what we're seeing here.
For what it's worth, I did an easy check in Sauce Labs (e.g., 'ondevicechange' in navigator.mediaDevices returns true in Safari 11.0) to make sure this still seems plausible. Since it looks OK—and it's definitely more helpful than showing false—I'm going to go ahead with approving and merging this for now, with the qualification that I'm not closing the door to a follow up PR that amends this (hopefully with some comprehensive test cases that help us understand what the full story is).
…icture * upstream/master: (1123 commits) Remove Chromium 89 from String.at / Array.at / TypedArray.at (mdn#8869) Add worker_support info for CacheStorage (mdn#8783) Remove several needless "Enabled by default" notes (mdn#8899) Add HTML global attribute nonce (mdn#8764) api.Navigator.vibrate - Firefox for Android doesn't vibrate (mdn#7172) Mark MediaSource's onsourceclose as not supported in Firefox (mdn#8881) Update Florian's ownership (mdn#8893) Mention fix for Chrome's broken PDF loading (mdn#8867) Fill out Chrome data for html.elements.source.{sizes,srcset} (mdn#8889) Weekly data release for 2021-01-28 Add text-decoration-thickness for Opera 73+ (mdn#8872) Update :is and :where pseudo-classes for Chrome (mdn#7375) Add note re Safari <9 partial srcset/sizes support (mdn#7353) Update data for when href (not xlink:href) can be used in SVG (mdn#6603) Add top-level await (mdn#8807) TouchList: Add Safari Desktop and Safari iOS versions (mdn#8848) Update Firefox versions to account for Firefox 85 release (mdn#8864) Fix page_action.show_matches support for Android (mdn#8844) Update Safari support for devicechange_event (mdn#8863) Add HTTPS-only to privacy.network (mdn#8830) ...
Per experiments done by @ddbeck [1], support begins with version 11, aligning with support for
ondevicechange.This seems to contradict what official documentation I can find. Changelogs[2] indicate support was added in technology preview version 72, and the change list for that release indicates support was committed[3] after the tag for Safari 11.1[4], but I'll defer to the experiments.
Fixes #8688
[1] #8688 (comment)
[2] https://webkit.org/blog/8547/release-notes-for-safari-technology-preview-72/
[3] https://trac.webkit.org/changeset/238796/webkit/
[4] https://trac.webkit.org/changeset/230984/webkit