Add entries for webkitOfflineAudioContext #9514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
In addition to not representing prefixed support, much of the existing data claimed support that was earlier than it really was. Chrome versions for webkitOfflineAudioContext and OfflineAudioContext were found with two mdn-bcd-collector tests: https://mdn-bcd-collector.appspot.com/tests/api/webkitOfflineAudioContext https://mdn-bcd-collector.appspot.com/tests/api/OfflineAudioContext/OfflineAudioContext Other Chromium data was mirrored. Safari 14 does not support the unprefixed constructor, that should be coming in Safari 14.1. Support for webkitOfflineAudioContext was confirmed in iOS 7, and so assumed to have been introduced in iOS 6, matching webkitAudioContext.
foolip
force-pushed
the
webkitOfflineAudioContext
branch
from
f50c059 to
96b81fe
Compare
foolip
commented
Mar 19, 2021
| @@ -52,14 +96,26 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/OfflineAudioContext/OfflineAudioContext", | |||
| "description": "<code>OfflineAudioContext()</code> constructor", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": "55", | |||
| "notes": "Before Chrome 59, the default values were not supported." | |||
There was a problem hiding this comment.
I couldn't figure out what these notes might be referring to so I removed them. Expecting to be asked by a reviewer to dig deeper, but taking my chances :)
There was a problem hiding this comment.
I gave a quick look for something which might even hint as to what this could be about and found nothing. I think this is the right call. 👍
ddbeck
approved these changes
Mar 25, 2021
| @@ -52,14 +96,26 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/OfflineAudioContext/OfflineAudioContext", | |||
| "description": "<code>OfflineAudioContext()</code> constructor", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": "55", | |||
| "notes": "Before Chrome 59, the default values were not supported." | |||
There was a problem hiding this comment.
I gave a quick look for something which might even hint as to what this could be about and found nothing. I think this is the right call. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to not representing prefixed support, much of the existing
data claimed support that was earlier than it really was.
Chrome versions for webkitOfflineAudioContext and OfflineAudioContext were
found with two mdn-bcd-collector tests:
https://mdn-bcd-collector.appspot.com/tests/api/webkitOfflineAudioContext
https://mdn-bcd-collector.appspot.com/tests/api/OfflineAudioContext/OfflineAudioContext
Other Chromium data was mirrored.
Safari 14 does not support the unprefixed constructor, that should be
coming in Safari 14.1.
Support for webkitOfflineAudioContext was confirmed in iOS 7, and so
assumed to have been introduced in iOS 6, matching webkitAudioContext.