Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spec-url of URL interface #21549

Merged
merged 2 commits into from
Dec 9, 2023
Merged

fix spec-url of URL interface #21549

merged 2 commits into from
Dec 9, 2023

Conversation

skyclouds2001
Copy link
Contributor

Summary

the spec-url of URL interface should be with hash #url, not #api

also normalize the spec-url of URL.canParse() and URL() to keep same with others

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 9, 2023
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 9, 2023 07:59
teoli2003
teoli2003 approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 1c97b82 into mdn:main Dec 9, 2023
@skyclouds2001 skyclouds2001 deleted the url branch December 9, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @teoli2003