Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA 256 Digest Authentication #8682

Closed
5 of 7 tasks
Rumyra opened this issue Sep 6, 2021 · 8 comments
Closed
5 of 7 tasks

SHA 256 Digest Authentication #8682

Rumyra opened this issue Sep 6, 2021 · 8 comments
Assignees
Labels
Content:HTTP HTTP docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Sep 6, 2021

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Possibly an update here https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Digest

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=472823

@gstrauss
Copy link

FYI, the lighttpd web server has supported HTTP Authentication method Digest with algorithm=SHA-256 (RFC 7616) since lighttpd 1.4.54 (May 2019). A few weeks ago, I tested lighttpd mod_auth with FF93 (alpha?) from the nightlies, and FF93 successfully authenticated using HTTP Auth Digest with algorithm=SHA-256. FF93 also correctly uses SHA-256 when lighttpd provides multiple WWW-Authenticate digest challenges (e.g. algorithm=SHA-256 and algorithm=MD5)

With FF93, Firefox joins Opera in supporting HTTP Authentication method Digest with algorithm=SHA-256. Chrome does not yet support Digest algorithm=SHA-256: https://bugs.chromium.org/p/chromium/issues/detail?id=1160478

@gstrauss
Copy link

BTW, https://en.wikipedia.org/wiki/Digest_access_authentication references Mozilla bug 472823 noting that Firefox does not (did not) support HTTP Auth Digest algorithm=SHA-256, so once FF93 is released, let's update the wikipedia page, too. (I'll try to remember.)

@hamishwillee
Copy link
Collaborator

@gstrauss Thanks! Opera is based on Chromium too nowdays (along with Edge) - is there some oddity that means they support this feature differently than Chrome?

@gstrauss
Copy link

gstrauss commented Sep 14, 2021

@hamishwillee Someone reported that Opera with HTTP auth Digest algorithm-SHA-256 worked with lighttpd 1.4.54 in a forum post near the beginning of 2020: https://redmine.lighttpd.net/boards/2/topics/8903 and https://redmine.lighttpd.net/boards/2/topics/8955 However, I have not checked Opera, and that may no longer be true if Opera switched from Presto-based to Chromium-based. Thanks for calling that out.

@hamishwillee
Copy link
Collaborator

@gstrauss Cool. I can almost guarantee that it isn't supported on Opera if it isn't on Chromium. That said, I have not tested this, and I thought Chromium did. Just FYI

  • I'm currently having to rewrite the MDN docs before I can do this properly - in particular the WWW-Authenticate headers assume Basic authentication. At the end of the process I hope that the docs are extensible - if someone wants to come along and write how to support oauth on MDN using this it will be fairly obvious how.
  • For versions etc it still isn't clear the best way to capture what works. I'm hoping in Browser compatibility data, but that depends a bit on that team agreeing.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Sep 20, 2021

FYI, I've done the bulk of the docs work for this now to satisfy the condition "The listed features are documented sufficiently on MDN". At least it is clear that "Basic authentication" isn't the only alternative. And if someone did want to do digest authentication, it would be clear where you got started (albeit you still "need" the spec for a detailed implementation).

Most of the remainder is getting review from BCD team - because I think it makes sense to include the things are supported by different browsers as a compatibility issue. If BCD disagree I may need to come back to the docs and try include that information there.

Upshot, this would be "OK" for release.

PS It would be nice if there was Parity in setup of Digest authentication for Apache, lighttpd but I don't see that as in scope/priority. It should be clear how/where you add that though, if needed.

@Rumyra
Copy link
Collaborator Author

Rumyra commented Sep 23, 2021

That's perfect - thank you @hamishwillee

@Rumyra Rumyra closed this as completed Sep 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 93 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTTP HTTP docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
None yet
Development

No branches or pull requests

5 participants