Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRLightProbe: Use a single event page #10373

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 8, 2021

Summary

The PR is a proposal to only use one event page for the reflectionchange event. It redirects Web/API/XRLightProbe/onreflectionchange to Web/API/XRLightProbe/reflectionchange_event and makes the reflectionchange_event page contain all the event related information.

BCD PR follows.

Motivation

See the discussion at https://github.com/mdn/content/discussions/9098

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Elchi3 Elchi3 requested review from a team as code owners November 8, 2021 12:53
@Elchi3 Elchi3 requested review from ddbeck and sideshowbarker and removed request for a team November 8, 2021 12:53
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/XRLightProbe
Title: XRLightProbe
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/XRLightProbe
Title: XRLightProbe
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRLightProbe/reflectionchange_event
Title: XRLightProbe: reflectionchange event
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit c7085e3 into mdn:main Nov 9, 2021
@Elchi3 Elchi3 deleted the xrlightprobe-event branch November 10, 2021 10:25
@Elchi3
Copy link
Member Author

Elchi3 commented Nov 10, 2021

Thanks for the merge, @sideshowbarker 👍

@ddbeck and I talked a bit about this PR and I opened #10431 to continue that conversation.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants