Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dropzone content #514

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Remove dropzone content #514

merged 1 commit into from
Dec 21, 2020

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 21, 2020

This attribute is gone for a long time and wasn't even documented properly.

I ran yarn content delete Web/HTML/Global_attributes/dropzone to deleted it instead of archiving given the content on the page was so minimal and there isn't really a benefit to preserve this in an archive.

Web/AP/HTMLElement/dropzone was mentioned but that page never existed. I remove the references.

BCD update is in mdn/browser-compat-data#8095

@Elchi3 Elchi3 requested review from a team as code owners December 21, 2020 11:25
@peterbe
Copy link
Contributor

peterbe commented Dec 21, 2020

One thing to keep in mind is mdn/yari#2224
We don't do any expiration of stuff once built and that issue is about triggering a deletion from S3.
But at least, and perhaps it's not so bad, the URLs you deleted will stop being in the latest sitemap XML files and at the same time, the old URLs will be 200 OK.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisdavidmills chrisdavidmills merged commit 1980248 into mdn:main Dec 21, 2020
@Elchi3 Elchi3 deleted the rm-dropzone branch December 22, 2020 11:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants