Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WorkerGlobalScope.close/onclose #7033

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jul 19, 2021

I've made both pages redirect to DedicatedWorkerGlobalScope.close

For mdn/browser-compat-data#11557

@Elchi3 Elchi3 requested review from a team as code owners July 19, 2021 10:10
@Elchi3 Elchi3 requested review from Rumyra and removed request for a team July 19, 2021 10:10
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WorkerGlobalScope
Title: WorkerGlobalScope
on GitHub
Flaw count: 8

  • macros:
    • /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
    • /en-US/docs/Web/API/WorkerGlobalScope/onrejectionhandled does not exist
    • /en-US/docs/Web/API/WorkerGlobalScope/onunhandledrejection does not exist
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/ServiceWorker_API
    • Can't resolve /en-US/docs/Web/Guide/Performance/Using_web_workers
  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Web_Workers_API
Title: Web Workers API
on GitHub
Flaw count: 12

  • macros:
    • /en-US/docs/Web/API/WindowBase64/atob redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/atob
    • /en-US/docs/Web/API/WindowBase64/btoa redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa
    • /en-US/docs/Web/API/WindowTimers/clearInterval redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/clearInterval
    • /en-US/docs/Web/API/WindowTimers/clearTimeout redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/clearTimeout
    • /en-US/docs/Web/API/WindowTimers/setInterval redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/setInterval
    • and 4 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Glossary/origin
    • Can't resolve /en-US/docs/Web/API/ServiceWorker_API
    • Can't resolve /en-US/docs/Web/API/ServiceWorker_API

URL: /en-US/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers
Title: Functions and classes available to Web Workers
on GitHub
Flaw count: 10

  • macros:
    • /en-US/docs/Web/API/WindowBase64/atob redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/atob
    • /en-US/docs/Web/API/WindowBase64/btoa redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa
    • /en-US/docs/Web/API/WindowTimers/clearInterval redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/clearInterval
    • /en-US/docs/Web/API/WindowTimers/clearTimeout redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/clearTimeout
    • /en-US/docs/Web/API/WindowTimers/setInterval redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope/setInterval
    • and 4 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/ServiceWorker_API

URL: /en-US/docs/Web/API/SharedWorkerGlobalScope
Title: SharedWorkerGlobalScope
on GitHub
Flaw count: 17

  • macros:
    • /en-US/docs/Web/API/WindowTimers redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope
    • /en-US/docs/Web/API/WindowBase64 redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope
    • /en-US/docs/Web/API/ApplicationCache does not exist
    • /en-US/docs/Web/API/WindowTimers redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope
    • /en-US/docs/Web/API/WindowBase64 redirects to /en-US/docs/Web/API/WindowOrWorkerGlobalScope
    • and 10 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Using_the_application_cache
    • Can't resolve /en-US/docs/Web/Guide/Needs_categorization/Functions_available_to_workers

External URLs

URL: /en-US/docs/Web/API/WorkerGlobalScope
Title: WorkerGlobalScope
on GitHub

No external URLs


URL: /en-US/docs/Web/API/Web_Workers_API
Title: Web Workers API
on GitHub


URL: /en-US/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers
Title: Functions and classes available to Web Workers
on GitHub

No external URLs


URL: /en-US/docs/Web/API/SharedWorkerGlobalScope
Title: SharedWorkerGlobalScope
on GitHub

No external URLs


URL: /en-US/docs/Web/API/SharedWorkerGlobalScope/close
Title: SharedWorkerGlobalScope.close()
on GitHub

No external URLs

@sideshowbarker sideshowbarker merged commit 1cdafbd into mdn:main Jul 19, 2021
@Elchi3 Elchi3 deleted the rm-worker-close branch July 19, 2021 10:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants