-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PaymentDetailsUpdate dictionary #8678
Conversation
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-09-07 01:27:16.694105) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I saw a reference that looked like it should be removed, otherwise this looks good to me.
@@ -66,7 +66,22 @@ <h3 id="Parameters">Parameters</h3> | |||
that the payment request's details need to be updated between instantiating the | |||
payment interface and the user beginning to interact with it. The promise should | |||
resolve with a {{domxref("PaymentDetailsUpdate")}} object containing the updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove this reference to {{domxref("PaymentDetailsUpdate")}}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack! I forgot to commit the reference removal... 😅 Fixed all the broken references now, and made sure to point them to the correct articles when applicable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I did wonder if there might be more than one reference :).Thanks!
This PR removes the
PaymentDetailsUpdate
dictionary from the MDN content, folding the content into the pages discussing the methods that use the dictionary. Part of the corresponding work to remove it from BCD: mdn/browser-compat-data#12277