Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PaymentDetailsUpdate dictionary #8678

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Remove PaymentDetailsUpdate dictionary #8678

merged 2 commits into from
Sep 7, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the PaymentDetailsUpdate dictionary from the MDN content, folding the content into the pages discussing the methods that use the dictionary. Part of the corresponding work to remove it from BCD: mdn/browser-compat-data#12277

@queengooborg queengooborg requested review from a team as code owners September 6, 2021 08:47
@queengooborg queengooborg requested review from ddbeck and jpmedley and removed request for a team September 6, 2021 08:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PaymentRequest/show
Title: PaymentRequest.show()
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/PaymentDetailsModifier does not exist
    • /en-US/docs/Web/API/PaymentShippingOption does not exist
    • /en-US/docs/Web/API/PaymentRequest/retry does not exist
    • /en-US/docs/Web/API/PaymentRequest/complete does not exist

URL: /en-US/docs/Web/API/PaymentRequest/paymentmethodchange_event
Title: PaymentRequest: paymentmethodchange event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaymentShippingOption does not exist
    • /en-US/docs/Web/API/PaymentMethodChangeEvent/updateWith does not exist

URL: /en-US/docs/Web/API/Payment_Request_API
Title: Payment Request API
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/BasicCardChangeDetails does not exist
    • /en-US/docs/Web/API/BasicCardErrors does not exist
    • /en-US/docs/Web/API/PaymentValidationErrors/paymentMethod does not exist

URL: /en-US/docs/Web/API/PaymentRequestUpdateEvent/updateWith
Title: PaymentRequestUpdateEvent.updateWith()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaymentDetailsModifier does not exist
    • /en-US/docs/Web/API/PaymentShippingOption does not exist

URL: /en-US/docs/Web/API/AddressErrors
Title: AddressErrors
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaymentMethodData does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.AddressErrors

External URLs

URL: /en-US/docs/Web/API/PaymentRequest/shippingaddresschange_event
Title: PaymentRequest: shippingaddresschange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PaymentRequest/show
Title: PaymentRequest.show()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PaymentRequest/paymentmethodchange_event
Title: PaymentRequest: paymentmethodchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Payment_Request_API
Title: Payment Request API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PaymentAddress/country
Title: PaymentAddress.country
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PaymentRequestUpdateEvent/updateWith
Title: PaymentRequestUpdateEvent.updateWith()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AddressErrors
Title: AddressErrors
on GitHub

No new external URLs

(this comment was updated 2021-09-07 01:27:16.694105)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I saw a reference that looked like it should be removed, otherwise this looks good to me.

@@ -66,7 +66,22 @@ <h3 id="Parameters">Parameters</h3>
that the payment request's details need to be updated between instantiating the
payment interface and the user beginning to interact with it. The promise should
resolve with a {{domxref("PaymentDetailsUpdate")}} object containing the updated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove this reference to {{domxref("PaymentDetailsUpdate")}}?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! I forgot to commit the reference removal... 😅 Fixed all the broken references now, and made sure to point them to the correct articles when applicable!

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I did wonder if there might be more than one reference :).Thanks!

@wbamberg wbamberg merged commit 1fdb7df into mdn:main Sep 7, 2021
@queengooborg queengooborg deleted the PaymentDetailsUpdate branch September 7, 2021 03:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants