Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authorisation header and extend www-auth with digest #9014

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Sep 17, 2021

This is continued update or HTTP authorisation docs for #8682

This updates the WWW-Authenticate and Authorization header docs with additional information. These headers are part of a framework, so the directives depend on the authentication method used. Prior to these updates the headers were written as though only the Basic authentication existed.

What I have tried to do is make this framework more obvious by including the directives and examples for both Basic and Digest authentication.

Part of the way though though I realised that it is very difficult to do justice to the Digest authentication - yes I could capture the entire algorithm, but the spec is pretty dense. I don't think we want to go to the point where people think this replaces the spec. What I want to do is give an overview that gives a good flavour of how it works, but makes it pretty clear that you do need to go to the spec if you're going to do anything more than superficial.

In other words, I don't think this is perfect, but I think it is better. Thoughts?

This part is pretty much done for now. I am planning on updating the BCD mdn/browser-compat-data#12446 to give better links into the spec. That is actually likely to be the most valuable part of this effort :-0

@hamishwillee hamishwillee requested a review from a team as a code owner September 17, 2021 07:08
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team September 17, 2021 07:08

## Specifications

| Specification | Title |
| ---------------------------------------------------- | -------------------------------------- |
| {{RFC("7235", "Authorization", "4.2")}} | HTTP/1.1: Authentication |
| {{RFC("7617")}} | The 'Basic' HTTP Authentication Scheme |
| {{RFC("7616")}} | HTTP Digest Access Authentication |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I have BCD item in progress to add these. Still under discussion. This is kind of "interim solution".

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2021

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Headers/Authorization
Title: Authorization
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Authorization

External URLs

URL: /en-US/docs/Web/HTTP/Headers/WWW-Authenticate
Title: WWW-Authenticate
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/Authorization
Title: Authorization
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Authentication
Title: HTTP authentication
on GitHub

(this comment was updated 2021-09-20 07:15:31.241031)

@hamishwillee hamishwillee mentioned this pull request Sep 17, 2021
7 tasks
@hamishwillee
Copy link
Collaborator Author

It doesn't sit well with me that this you still need to go to the spec to get detail. But it is still better than it was/more useful than over-promoting the basic authentication.

So, merging.

@hamishwillee hamishwillee merged commit 789fce8 into mdn:main Sep 20, 2021
@hamishwillee hamishwillee deleted the httpauth2 branch September 20, 2021 23:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants