Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StorageEstimate dictionary from MDN #9718

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Remove StorageEstimate dictionary from MDN #9718

merged 2 commits into from
Oct 10, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the documentation for the StorageEstimate dictionary from MDN, folding its information into the StorageManager.estimate() method that utilizes it. Correlates with removal in BCD, see mdn/browser-compat-data#12772.

@queengooborg queengooborg requested a review from a team October 10, 2021 14:21
@queengooborg queengooborg requested review from a team as code owners October 10, 2021 14:21
@queengooborg queengooborg requested review from schalkneethling and sideshowbarker and removed request for a team October 10, 2021 14:21
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2021

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Storage_API
Title: Storage API
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Using_the_application_cache

External URLs

URL: /en-US/docs/Web/API/Storage_API
Title: Storage API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/StorageManager
Title: StorageManager
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/StorageManager/estimate
Title: StorageManager.estimate()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Cache
Title: Cache
on GitHub

No new external URLs

(this comment was updated 2021-10-10 22:39:04.066034)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you

@hamishwillee hamishwillee merged commit 71a484e into mdn:main Oct 10, 2021
@queengooborg queengooborg deleted the StorageEstimate branch October 11, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants