From 4e331b38cd5d8be134f4836c7e70a19ae6a631a3 Mon Sep 17 00:00:00 2001 From: Florian Dieminger Date: Thu, 13 Feb 2025 15:04:42 +0100 Subject: [PATCH] fix(templ): htmlelement/htmlxref don't lowercase This was producing invalid urls in some cases. --- .../rari-doc/src/templ/templs/links/htmlxref.rs | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/crates/rari-doc/src/templ/templs/links/htmlxref.rs b/crates/rari-doc/src/templ/templs/links/htmlxref.rs index 1fa3079d..3b49db35 100644 --- a/crates/rari-doc/src/templ/templs/links/htmlxref.rs +++ b/crates/rari-doc/src/templ/templs/links/htmlxref.rs @@ -1,5 +1,3 @@ -use std::borrow::Cow; - use rari_templ_func::rari_f; use rari_types::AnyArg; @@ -13,16 +11,11 @@ pub fn htmlxref( anchor: Option, _: Option, ) -> Result { - let display = display.as_deref().filter(|s| !s.is_empty()); - let element_name = element_name.to_lowercase(); + let display = display.filter(|s| !s.is_empty()); let mut code = false; - let display = display.map(Cow::Borrowed).unwrap_or_else(|| { - if element_name.contains(' ') { - Cow::Borrowed(element_name.as_str()) - } else { - code = true; - Cow::Owned(format!("<{element_name}>")) - } + let display = display.unwrap_or_else(|| { + code = true; + format!("<{element_name}>") }); let mut url = format!( "/{}/docs/Web/HTML/Element/{}",