Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

U - Fix CSS linter errors: data.constituent_properties errors #3323

Closed
1 task done
wbamberg opened this issue Jun 1, 2020 · 6 comments
Closed
1 task done

U - Fix CSS linter errors: data.constituent_properties errors #3323

wbamberg opened this issue Jun 1, 2020 · 6 comments
Assignees
Labels
Content:CSS This is related to CSS content User Story Incremental value deliverable witin a Sprint / Iteration cycle and meeting part of an Epic's AC

Comments

@wbamberg
Copy link

wbamberg commented Jun 1, 2020

For shorthand properties we've defined a new ingredient "data.constituent_properties". The linter will check that shorthand property pages correctly include this ingredient.

Acceptance criteria

@Elchi3 Elchi3 added the Content:CSS This is related to CSS content label Jun 2, 2020
@Elchi3 Elchi3 added this to the India Juliette S3 Q2 2020) milestone Jun 2, 2020
@wbamberg
Copy link
Author

wbamberg commented Jul 10, 2020

According to the spreadsheet there are 58 pages that generate this error. However, this includes prefixed properties, some of which we might want to archive. So, as in all these stories, it makes sense to work on the unprefixed properties first, while we work out which prefixed ones we might want to archive.

In effect this error is because in the recipe defining the structure and content for CSS shorthand property pages (https://github.com/mdn/stumptown-content/blob/master/recipes/css-shorthand-property.yaml) we have introduced a new mandatory section. The section is named data.constituent_properties and its syntax is defined in the spec: https://github.com/mdn/stumptown-content/blob/master/project-docs/linter-spec.md#dataconstituent_properties.

The section is placed after the interactive example and before the "Syntax" section.

I've made an example here: https://wiki.developer.mozilla.org/en-US/docs/User:wbamberg/shorthand-property#Constituent_properties of what it might look like.

@chinikes chinikes added the User Story Incremental value deliverable witin a Sprint / Iteration cycle and meeting part of an Epic's AC label Jul 29, 2020
@chrisdavidmills
Copy link
Contributor

@wbamberg these are all done except for:

  • all, which we'vealready discussed.
  • -moz-outline-radius, which is a non-standard thing, and therefore we are probably going to archive it?

Do you want me to leave this open, or close and record the stragglers somewhere else?

@wbamberg
Copy link
Author

Thanks for doing all these Chris!

@wbamberg these are all done except for:

  • all, which we'vealready discussed.

Yes, let's file a separate issue to update the linter for this case.

  • -moz-outline-radius, which is a non-standard thing, and therefore we are probably going to archive it?

I don't think just being nonstandard is a reason to archive something. I believe the general rule is that they have to be unavailable to web content in any browsers for at least 2 years (see also #3491). -moz-outline-radius is available to web pages, as the live sample shows.

Do you want me to leave this open, or close and record the stragglers somewhere else?

I'd like to keep this open until these 2 are addressed.

@wbamberg
Copy link
Author

I've filed mdn/stumptown-content#526 for dealing with all.

@chrisdavidmills
Copy link
Contributor

Nice one @wbamberg. Yup, I was a bit hasty on -moz-outline-radius — I've fixed that one too now.

@wbamberg
Copy link
Author

As discussed in mdn/stumptown-content#526, I've re-tagged all to be a normal property and removed the "Constituent properties" section. We now get zero "data.constituent_properties" errors and this story can be closed :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS This is related to CSS content User Story Incremental value deliverable witin a Sprint / Iteration cycle and meeting part of an Epic's AC
Projects
None yet
Development

No branches or pull requests

4 participants