Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro - Meta - Remove transclusion calls of {{EmbedLiveSample}} (Parity with mdn/content/issues/15872) #5716

Open
8 of 9 tasks
SphinxKnight opened this issue May 17, 2022 · 6 comments
Labels
l10n-pt-br Issues related to Brazilian Portuguese

Comments

@SphinxKnight
Copy link
Member

SphinxKnight commented May 17, 2022

See mdn/content#15872, {{EmbedLiveSample}} may use sources from other pages.
Looking for this pattern EmbedLiveSample *\([^,]*,[^,]*,[^,]*,[^,]*, *'[^'][^']*' as of today, we also find occurrences in mdn/translated-content.

@SphinxKnight SphinxKnight added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-de (retired) Issues related to German content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels May 17, 2022
@cw118
Copy link
Member

cw118 commented Jun 22, 2022

l10n-fr taken care of thanks to @SphinxKnight 🎉

@cw118 cw118 removed the l10n-fr Issues related to French content. label Jun 22, 2022
@mfuji09
Copy link
Collaborator

mfuji09 commented Aug 5, 2022

ja is done.

@queengooborg queengooborg added this to the Macros removal milestone Aug 9, 2022
@yin1999 yin1999 removed the l10n-zh Issues related to Chinese content. label Aug 21, 2022
@yin1999 yin1999 removed the l10n-de (retired) Issues related to German content. label Aug 30, 2022
@mfuji09 mfuji09 removed the l10n-ja Issues related to Japanese content. label Oct 2, 2022
@Graywolf9
Copy link
Contributor

Graywolf9 commented Nov 15, 2022

es is donde

runnign: rg -i "EmbedLiveSample *\([^,]*,[^,]*,[^,]*,[^,]*, *'[^'][^']*'" only get the macro description file

Also, that regexes didn't use double quotes.

with rg 'EmbedLiveSample *\([^,]*,[^,]*,[^,]*,[^,]*, *"[^"][^"]*"' -i to search it only left files that still using transclusion in en-US too

@Graywolf9 Graywolf9 removed the l10n-es Issues related to Spanish content. label Jan 27, 2023
@sashasushko
Copy link
Member

Hi 👋 I'm not sure that I understood the main idea of this issue for 100%. Can someone please look at PR to ru locale? Just few of changed files, not of all.

@sashasushko
Copy link
Member

Done for ru locale

@hochan222
Copy link
Member

Done for ko locale

@hochan222 hochan222 removed l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. labels Aug 14, 2023
@yin1999 yin1999 moved this to Archive/Closed in MDN translated-content l10n-zh May 29, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in l10n-ko Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese
Projects
Status: Archive/Closed
Status: ✅ Done
Development

No branches or pull requests

8 participants