Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In pr review, the fallback images are not shown #7648

Closed
yin1999 opened this issue Aug 14, 2022 · 1 comment
Closed

In pr review, the fallback images are not shown #7648

yin1999 opened this issue Aug 14, 2022 · 1 comment
Labels
system Infrastructure and configuration for the project

Comments

@yin1999
Copy link
Member

yin1999 commented Aug 14, 2022

What page(s) did you find the problem on?

Pr review:

https://pr7646.content.dev.mdn.mozit.cloud/zh-CN/docs/Web/Guide/Audio_and_video_delivery/Adding_captions_and_subtitles_to_HTML5_video

Specific page section or heading?

案例

What is the problem?

The image is not shown there, because it is a fallback (reference to mdn/content, but this file is not in built artifact)

What did you expect to see?

While we can tell if a referenced image exists based on its border shape, it would be better to include the actual image.

Solution

copy files from mdn/content

Because we can got all of those changed markdown or html file by {{env.GIT_DIFF_CONTENT}}, so whether it's a good idea to copy all non html/markdown file with the same dir in mdn/content.

In this way, we don't need to redesign the build logic in mdn/yari. But the built artifact may contain some not-used files.

redesign mdn/yari build logic

We should copy those referenced fallback images when build a l10n document. This may be a little difficult. But this will help with local content build (the built out files can be served directlly).

/cc @SphinxKnight, @schalkneethling, @mdn/core-dev

@yin1999
Copy link
Member Author

yin1999 commented Jul 18, 2023

This should be fixed by mdn/yari#7917.

@yin1999 yin1999 closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

No branches or pull requests

1 participant