You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The image is not shown there, because it is a fallback (reference to mdn/content, but this file is not in built artifact)
What did you expect to see?
While we can tell if a referenced image exists based on its border shape, it would be better to include the actual image.
Solution
copy files from mdn/content
Because we can got all of those changed markdown or html file by {{env.GIT_DIFF_CONTENT}}, so whether it's a good idea to copy all non html/markdown file with the same dir in mdn/content.
In this way, we don't need to redesign the build logic in mdn/yari. But the built artifact may contain some not-used files.
redesign mdn/yari build logic
We should copy those referenced fallback images when build a l10n document. This may be a little difficult. But this will help with local content build (the built out files can be served directlly).
What page(s) did you find the problem on?
Pr review:
https://pr7646.content.dev.mdn.mozit.cloud/zh-CN/docs/Web/Guide/Audio_and_video_delivery/Adding_captions_and_subtitles_to_HTML5_video
Specific page section or heading?
案例
What is the problem?
The image is not shown there, because it is a fallback (reference to mdn/content, but this file is not in built artifact)
What did you expect to see?
While we can tell if a referenced image exists based on its border shape, it would be better to include the actual image.
Solution
copy files from mdn/content
Because we can got all of those changed markdown or html file by
{{env.GIT_DIFF_CONTENT}}
, so whether it's a good idea to copy all non html/markdown file with the same dir in mdn/content.In this way, we don't need to redesign the build logic in mdn/yari. But the built artifact may contain some not-used files.
redesign mdn/yari build logic
We should copy those referenced fallback images when build a l10n document. This may be a little difficult. But this will help with local content build (the built out files can be served directlly).
/cc @SphinxKnight, @schalkneethling, @mdn/core-dev
The text was updated successfully, but these errors were encountered: