fix(macros/EmbedLiveSample): un-deprecate the 6th parameter (allowed features) #10106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @bsmth |
bsmth
reviewed
Dec 1, 2023
caugner
changed the title
caugner
approved these changes
Dec 1, 2023
|
Thanks @teoli2003! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 6th parameter of the macro is still in use, and we can't get rid of it.
Problem
A flaw is added to the page when the 6th parameter is used
Solution
Change the test to not generate a flaw when the 6th parameter is in use.
Screenshots
No UI change
How did you test this change?
I locally tested with an example page