enhance(macros/EmbedYouTube): add optional title attribute #10504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
requested changes
Feb 28, 2024
Co-authored-by: Claas Augner <[email protected]>
bsmth
changed the title
caugner
changed the title
caugner
approved these changes
May 3, 2024
|
FYI @fiji-flo |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: reverting to change title only per reviewer feedback
Summary
This PR adds a few more parameters to the YouTube embed macro.
Problem
Currently the title, width and height are hardcoded, so it would be nice to be able to customize these.
Solution
Add three optional parameters that fall back to current hardcoded values if not given.
Screenshots
How did you test this change?
{{EmbedYouTube("hs3piaN4b5I", "Awesome Flexbox video", 200, 100)}}