Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-help): remove decorative images from a11y tree #10520

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 14, 2024

Summary

(MP-707)

Problem

We have decorative SVGs on the AI Help landing page, and the Developer Tools flagged that they did not have a text label.

Solution

Specify their ARIA role="none" to remove them from the accessibility tree.


How did you test this change?

Checked via the Firefox Developer Tools by opening the "Accessibility" tab, setting "Check for issues: all" and verifying that the SVGs no longer appear.

@caugner caugner requested a review from a team as a code owner February 14, 2024 14:25
@github-actions github-actions bot added plus work around features related to MDN Plus plus:ai-help labels Feb 14, 2024
@caugner caugner added the ♿ a11y An MDN Web Docs accessible by everyone label Feb 14, 2024
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit 575420c into main Feb 28, 2024
14 checks passed
@caugner caugner deleted the remove-decorative-images-from-a11y-tree branch February 28, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿ a11y An MDN Web Docs accessible by everyone plus:ai-help plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants