Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(footer): add Bluesky link #12538

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jan 29, 2025

Summary

fix #12537

Problem

As written in the issue, MDN now has the official Bluesky account. But there is no Bluesky icon link on the social media section on the MDN footer.

Solution

Adding a new Bluesky link with the icon. This is almost identical PR I sent for the Mastodon icon in the past PR (#9689).

For Bluesky icon svg, I chose the fa6-brands:bluesky one from Iconify: https://icon-sets.iconify.design/?query=bluesky


Screenshots

I tested two screens (wide and mobile) x two themes (light and dark).

Before

screenshot of mdn website footer, no bluesky icon in social media link section

After

mobile screen screenshot of mdn website footer, Bluesky icon is at the lest in social media link section next to Mastodon icon

same in mobile screen in dark theme

same in wide screen in light theme

same in dark theme

@shuuji3 shuuji3 requested a review from a team as a code owner January 29, 2025 15:51
@shuuji3 shuuji3 mentioned this pull request Jan 29, 2025
3 tasks
@caugner caugner requested a review from pransh15 February 3, 2025 12:22
@pransh15
Copy link

Thanks for starting this, @shuuji3! 🙌

Copy link

@pransh15 pransh15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for this. 🚀

@caugner caugner merged commit c698ef5 into mdn:main Feb 26, 2025
13 checks passed
@shuuji3 shuuji3 deleted the chore/add-bluesky-link branch February 26, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluesky link is missing on footer
3 participants