fix(workflows): rate limit downloading ripgrep #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may also need this in content and translated-content |
caugner
approved these changes
May 16, 2023
|
Gonna merge this for now, and revert later with my refactor, to fix the immediate problem.
@yin1999 I'm going to attempt to remove our dependency on ripgrep soon (after working on some other issues) if I'm not successful I'll open a similar PR to this over there. But if I take too long, or things get too frustrating with failing jobs, feel free to open a PR doing the same as this and ping me to review. |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We hit a rate limit when installing yarn packages in CI, and the job fails as a result, requiring manual intervention.
Solution
Setting the
GITHUB_TOKENenvironment variable should use a per-token rate limit, rather than a public one: https://github.com/microsoft/vscode-ripgrep#github-api-limit-noteHow did you test this change?
Testing in this draft PR.