chore(tools): better error handling for yarn tool spas command
#9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yin1999
reviewed
Jul 20, 2023
caugner
reviewed
Jul 20, 2023
caugner
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #8950 (comment)
Problem
The blogs repo is not public so
BLOG_ROOTenvironment variable has not been advertised. If the variable is not set thenyarn tool spascommand throws an error which doesn't make sense at all.Solution
If the variable is not set then don't run ripgrep command.
How did you test this change?
Tested the code with the variable set and unset in the
.envfile. Also set the variable to unrelated dir to test match not found message.