fix(placement): fix firing multiple impressions #9631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
commented
Sep 11, 2023
LeoMcA
requested changes
Sep 11, 2023
LeoMcA
approved these changes
Sep 12, 2023
| timer.current = { timeout: -1 }; | ||
| }, [pong, gleanClick, typ]); | ||
|
|
||
| const place = useCallback((node: HTMLElement | null) => { |
There was a problem hiding this comment.
nit (in my own code): we already have a node const declared in the scope above. We could do what I did with the intersection observer hook and do something like: const [nodeState, setNodeState] = useState<HTMLElement>(); instead
client/src/document/index.test.tsx
Outdated
| import { render, waitFor } from "@testing-library/react"; | ||
|
|
||
| import { Document } from "./index"; | ||
|
|
||
| declare var global: Window; | ||
|
|
||
| // TODO: move this somewhere better once we have more use cases. | ||
| class IntersectionObserver { |
There was a problem hiding this comment.
Considering our chat about progressive enhancement the other day, might it be better to remove this from the tests, and just ensure we wrap our code with if (typeof IntersectionObserver !== "undefined") or similar, as necessary?
Unify sendViewed and empty placement.
by leo
fiji-flo
force-pushed
the
fix-placement-ping
branch
from
abb30e1 to
bd198f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unify
sendViewedand empty placement.Problem
We did not cancel our timer properly.
Solution
Use an unified
sendViewedfunction.How did you test this change?
Locally