Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to recognize definition term hyperlinks in definition lists #9810

Closed
OnkarRuikar opened this issue Oct 13, 2023 · 1 comment · Fixed by #9811
Closed

Unable to recognize definition term hyperlinks in definition lists #9810

OnkarRuikar opened this issue Oct 13, 2023 · 1 comment · Fixed by #9811
Assignees
@caugner
Labels
🐛 bug Something isn't working, or isn't working as expected effort: small This task is a small effort. has PR Issues that already have a PR p1 We will address this soon and will provide capacity from our team for it in the next few releases. regression ux make the user experience awesome

Comments

@OnkarRuikar
Copy link
Contributor

OnkarRuikar commented Oct 13, 2023 •
edited
Loading

Summary

After #8413 landed all the definition terms got same formatting. Now it is not possible to recognize hyperlinks for these terms.

URL

https://developer.mozilla.org/en-US/docs/Web/CSS/border

Expected behavior

The definition term hyperlinks be recognizable.
This is how it looked prior to the changes:
https://web.archive.org/web/20231011150428/https://developer.mozilla.org/en-US/docs/Web/CSS/border#values

_1

Not asking to completely revert the changes but to fix/improve the implementation.

Actual behavior

_3

cc/ @estelle
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 13, 2023
@OnkarRuikar OnkarRuikar mentioned this issue Oct 13, 2023
Merged
@caugner caugner added 🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases. ux make the user experience awesome regression effort: small This task is a small effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 13, 2023
@caugner caugner self-assigned this Oct 13, 2023
@caugner caugner mentioned this issue Oct 13, 2023
Merged
@caugner caugner added the has PR Issues that already have a PR label Oct 13, 2023
@estelle
Copy link
Member

estelle commented Oct 13, 2023

Thank you!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caugner caugner

Labels
🐛 bug Something isn't working, or isn't working as expected effort: small This task is a small effort. has PR Issues that already have a PR p1 We will address this soon and will provide capacity from our team for it in the next few releases. regression ux make the user experience awesome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): restore behavior of description term links mdn/yari
3 participants
@estelle @caugner @OnkarRuikar