fix(build): sort meta files #9899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids this file from showing up when comparing two builds.
LeoMcA
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The content of
allBrowserCompat.txt,metadata.jsonandsitemaps/*/sitemap.xml.gzdiffers from build to build, because the order of its values is not deterministic.Solution
Sort the values before writing them to the files.
How did you test this change?
yarn build --locale en-us -nand looked atallBrowserCompat.txtandmetadata.json.yarn build --locale en-us --sitemap-indexand looked atsitemaps/en-us/sitemap.xml.gz(withzless).