fix(sidebar): unify sections by declaring them with CSS classes #9930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9917.
Problem
<a>
and<strong>
within each other.Solution
no-link
to add missing padding to unlinked section titles (all links in the sidebar already have additional padding).section
for sidebar section titles and remove<strong>
tags.margin-top: 1.5rem
for all section titles (increases spacing for most, decreases spacing slightly for some).Note: This has the (positive?) side-effect that section titles are now also highlighted if they are the current page.
Screenshots
How did you test this change?
Ran
yarn && yarn dev
locally and looked at the following pages: