Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

? in a title/URL is not escaped properly #67

Closed
kmaasrud opened this issue Jan 16, 2022 · 0 comments
Closed

? in a title/URL is not escaped properly #67

kmaasrud opened this issue Jan 16, 2022 · 0 comments
Assignees
@kmaasrud
Labels
bug Something isn't working
Milestone
0.5.1

Comments

@kmaasrud
Copy link
Member

Our escape function does not work because pulldown-cmarks's escape_href function has an oversight for ? characters. Additionally, mdBook's TOC helper does not escape URLs at all.

This is easily solved by manually escaping ?s in our escape_special_chars function and making sure it's used in our TOC helper.
@kmaasrud kmaasrud added the bug Something isn't working label Jan 16, 2022
@kmaasrud kmaasrud added this to the 0.5.1 milestone Jan 16, 2022
@kmaasrud kmaasrud self-assigned this Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmaasrud kmaasrud

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
1 participant
@kmaasrud