Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Travis builds are failing on install of Protractor version that's incompatible with Node 4 & 5 #1705

Closed
mleanos opened this issue Jan 24, 2017 · 3 comments

Comments

@mleanos
Copy link
Member

mleanos commented Jan 24, 2017

Currently, the Travis CI builds are failing on Node 4 & 5, due to the latest version of Protractor being installed. Consequently, a version of the webdriver-manager package is installed that is incompatible with Node 4 & 5.

image

https://github.com/meanjs/mean/blob/master/.travis.yml#L35

We're not using Protractor directly in the project, since we're using gulp-protractor. The latter installs the expected version of Protractor, thus a compatible version of webdriver-manager.

I don't have much experience with Travis CI, and I'm not aware of a way of testing our .travis.yml configuration, short of committing to a PR.

Could we just change the referenced line in the Travis build config, to be npm install gulp-protractor@">=3.0.0 <4.0.0" to match our version of gulp-protractor? Moreover, why do we have to install Protractor at all, before the project's dev dependencies are installed?

@meanjs/contributors @simison @sujeethk @hyperreality

@lirantal
Copy link
Member

lirantal commented Apr 1, 2017

@mleanos I don't remember the historical reasons for the travis.yml file but you can definitely open a PR with the suggested change and see how the build works.

@codydaig
Copy link
Member

codydaig commented Apr 1, 2017

What @lirantal said. Go for the changes and hope for the best! I'd be curious to see if we don't need gulp-protractor directly in the travis.yml file. That would be the ideal situation.

@lirantal
Copy link
Member

lirantal commented Apr 9, 2017

@mleanos this PR for protractor basically sets up the build in travis so that we don't run E2E on unsupported versions like 4 & 5, and only for 6.9 and higher.
Reference: #1752

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants