Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Sandboxed JavaScript Injection Data Theorem finding #12

Open
utsavDave97 opened this issue Jul 17, 2024 · 6 comments
Open

Enable Sandboxed JavaScript Injection Data Theorem finding #12

utsavDave97 opened this issue Jul 17, 2024 · 6 comments

Comments

@utsavDave97
Copy link

  • Hello, we have a Data theorem finding for our app for Enable Sandboxed JavaScript Injection the following code:
-[_TtC18MedalliaDigitalSDK27LoadSingleResourceOperation start]
-[_TtC18MedalliaDigitalSDK27MDUIModalFormViewController .cxx_destruct]
-[_TtC18MedalliaDigitalSDK27MDUIModalFormViewController initWithCoder:]
@"/Users/jenkins/workspace/igital_Mobile_MobileSDK-iOS_v4.4@2/MobileSDK/Components/Form/MDUIBaseFormViewController+Communicator.swift"
@" getDeviceData was called "
@"NebulaForm.setDeviceData('"
-[_OBJC_CLASS_$_NSBundle mainBundle]
-[_OBJC_CLASS_$_NSBundle bundleIdentifier]
-[(id) evaluateJavaScript:completionHandler:]
Screenshot 2024-07-17 at 11 55 03 AM

We are using medallia-digital-ios-sdk (4.5.1)

Recommendation:

When injecting JavaScript into a web page, utilize the iOS 14 APIs that allow sandboxed JavaScript execution. To do so, pass a WKContentWorld instance for the App JavaScript to execute within, which ensures code isolation from third-party JavaScript.

I was wondering if this is something which could be fixed. Thank you.

@OriMedallia
Copy link
Collaborator

Hi,

Please contact your Digital Expert with all the information including a video of the all the information you can share about this.
Once the Digital Expert raises a ticket, we'll be able to prioritize it for the team.

Thanks,
Ori

@utsavDave97
Copy link
Author

@OriMedallia Thank you for your comment. Would you happen to know whats the tech risk for this finding?

@OriMedallia
Copy link
Collaborator

We'll have to investigate once a ticket is raised, but I can tell you that we have this code from day 1 (over 6 years, hundreds of customers are using it and we never had any issues.

In the investigation we'll check the option to start using WKContentWorld for iOS 14 and above

@utsavDave97
Copy link
Author

@OriMedallia True that. Thank you again. Let me see about ticket. Appreciate it.

@utsavDave97
Copy link
Author

@OriMedallia Also, would you happen to know how to raise a ticket?

@OriMedallia
Copy link
Collaborator

@utsavDave97 Please contact your Medallia Digital Expert. He's your company's contact person.
Let me know the name of the company and the app you're working on and I'll try to help on my side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants