From 5b09eac1e72f30ce2eef7cb41b56b65d0dd6b3dc Mon Sep 17 00:00:00 2001 From: Sebastian Rindom Date: Thu, 21 Mar 2024 10:35:54 +0100 Subject: [PATCH 1/3] fix(medusa): migrate with feature flag --- packages/medusa/src/commands/migrate.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/medusa/src/commands/migrate.js b/packages/medusa/src/commands/migrate.js index 2182065e05921..4d53a059e438b 100644 --- a/packages/medusa/src/commands/migrate.js +++ b/packages/medusa/src/commands/migrate.js @@ -72,9 +72,8 @@ const main = async function ({ directory }) { args.shift() args.shift() - const featureFlagRouter = featureFlagLoader(configModule) const configModule = configModuleLoader(directory) - const dataSource = await getDataSource(directory) + const featureFlagRouter = featureFlagLoader(configModule) if (args[0] === "run") { if (featureFlagRouter.isFeatureEnabled(MedusaV2Flag.key)) { @@ -91,6 +90,7 @@ const main = async function ({ directory }) { { registerInContainer: false } ) } else { + const dataSource = await getDataSource(directory) await dataSource.runMigrations() await dataSource.destroy() await runIsolatedModulesMigration(configModule) From c8a9be5fe11015597dd8f0ddc72935197a979fbe Mon Sep 17 00:00:00 2001 From: Sebastian Rindom Date: Thu, 21 Mar 2024 10:42:25 +0100 Subject: [PATCH 2/3] fix --- packages/medusa/src/commands/migrate.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/medusa/src/commands/migrate.js b/packages/medusa/src/commands/migrate.js index 4d53a059e438b..4b9c45444491c 100644 --- a/packages/medusa/src/commands/migrate.js +++ b/packages/medusa/src/commands/migrate.js @@ -101,11 +101,13 @@ const main = async function ({ directory }) { Logger.info("Migrations completed.") } else if (args[0] === "revert") { + const dataSource = await getDataSource(directory) await dataSource.undoLastMigration({ transaction: "all" }) await dataSource.destroy() await revertIsolatedModulesMigration(configModule) Logger.info("Migrations reverted.") } else if (args[0] === "show") { + const dataSource = await getDataSource(directory) const unapplied = await dataSource.showMigrations() Logger.info(unapplied) await dataSource.destroy() From 981056f73a8123bae5faabeeb8970e2fe2ed3ba7 Mon Sep 17 00:00:00 2001 From: Sebastian Rindom Date: Thu, 21 Mar 2024 10:43:17 +0100 Subject: [PATCH 3/3] Create small-guests-whisper.md --- .changeset/small-guests-whisper.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/small-guests-whisper.md diff --git a/.changeset/small-guests-whisper.md b/.changeset/small-guests-whisper.md new file mode 100644 index 0000000000000..065dd8b041568 --- /dev/null +++ b/.changeset/small-guests-whisper.md @@ -0,0 +1,5 @@ +--- +"@medusajs/medusa": patch +--- + +fix(medusa): ensure feature flags are loaded properly in migrate command