Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charabia can't be built in Windows due to jemallocator used only for bench #314

Closed
tats-u opened this issue Oct 10, 2024 · 1 comment · Fixed by #315
Closed

charabia can't be built in Windows due to jemallocator used only for bench #314

tats-u opened this issue Oct 10, 2024 · 1 comment · Fixed by #315

Comments

@tats-u
Copy link
Contributor

tats-u commented Oct 10, 2024

I want to improve and test charabia in Windows but jemallocator fails to be built.
The platforms supported by jemallocator are limited, so it should be disabled in unsupported platforms.
@tats-u tats-u mentioned this issue Oct 10, 2024
Merged
3 tasks
@tats-u
Copy link
Contributor Author

tats-u commented Oct 11, 2024 •
edited
Loading

I wonder how about mimalloc

@meili-bors meili-bors bot closed this as completed in 344d180 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace jemalloc(ator) with mimalloc, which covers wider platforms tats-u/charabia
1 participant
@tats-u