Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React JSX PPX umbrella issue #459

Closed
anmonteiro opened this issue Nov 24, 2022 · 7 comments
Closed

React JSX PPX umbrella issue #459

anmonteiro opened this issue Nov 24, 2022 · 7 comments

Comments

@anmonteiro
Copy link
Member

Extracted from this comment

We should make a note to remove the -bs-jsx-3 stuff eventually. Here's my rough plan:

  • move the React JSX PPX out of the compiler (Add react-jsx-ppx as a separate package #396)
  • distribute this new package with melange
  • nudge users to change to (preprocess (pps reactjs_jsx_ppx)) rather than (flags :standard -bs-jsx 3)
  • Delete this line in the merlin generated config
@jchavarri
Copy link
Member

nudge users to change to (preprocess (pps reactjs_jsx_ppx)) rather than (flags :standard -bs-jsx 3)

as @rgrinberg pointed out, this won't be possible until everything in the ppx (fast pipe, ## operator, etc) are migrated to another melange-ppx, so there is one missing step in the list.

@anmonteiro
Copy link
Member Author

What's the part that's not possible? can't we use the melange ppx without -bs-jsx 3?

@jchavarri
Copy link
Member

Sorry, I should have pointed to this item instead:

Delete this line in the merlin generated config

We can't remove the hack in merlin generated config until melange ppx is available independently.

@anmonteiro
Copy link
Member Author

Oh I meant delete the bs-jsx arg from the Merlin config, not the whole line

@jchavarri
Copy link
Member

I created #463 to track it.

@davesnx
Copy link
Member

davesnx commented Dec 2, 2022

Updated #396 without being a breakage for users.

@jchavarri
Copy link
Member

I think this issue is now done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants