Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: speed up discovery, just discover selected tables #1048

Closed
s7clarke10 opened this issue Oct 6, 2022 · 3 comments
Closed

[Feature]: speed up discovery, just discover selected tables #1048

s7clarke10 opened this issue Oct 6, 2022 · 3 comments
Labels

Comments

@s7clarke10
Copy link
Contributor

Feature scope

Taps (catalog, state, stream maps, etc.)

Description

I'm not sure if this is a capability of the SDK for database taps or not.

We were finding that the Discovery of Tables running in an ephemeral container deployment where you always have to discover not satisfactory when you have a large number of tables in the source system. On a particular database, this was taking 2-5 minutes due to the slowness of the Oracle Data Dictionary and the large number of tables.

We decided that we would add a feature to just discover selected tables i.e., tables set in the config or in the MELTANO __SELECT environment variable. If that config item was set, then the discovery was limited to just the selected tables. With that in place discover went from 2-5 minutes to a few seconds.

This was the particular change that we placed in pipelinewise-tap-oracle to support this feature.

s7clarke10/pipelinewise-tap-oracle@d348c4e
s7clarke10/pipelinewise-tap-oracle@d545a7d

Just sharing this idea as I believe it is a helpful feature.

@s7clarke10 s7clarke10 added kind/Feature New feature or request valuestream/SDK labels Oct 6, 2022
@s7clarke10 s7clarke10 changed the title [Feature]: speed up discovery, just discover selected table [Feature]: speed up discovery, just discover selected tables Oct 6, 2022
@kgpayne
Copy link
Contributor

kgpayne commented Oct 26, 2022

+1 Ran into slow discovery with tap-snowflake too, which would benefit from this feature.

@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Duplicate of #1234

@edgarrmondragon edgarrmondragon marked this as a duplicate of #1234 Jul 20, 2023
@edgarrmondragon edgarrmondragon closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants