Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move SQLConnector into a separate module, for use by both SQLStream and SQLSink #1091

Merged
merged 11 commits into from
Oct 24, 2022

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Oct 20, 2022

@kgpayne
Copy link
Contributor Author

kgpayne commented Oct 20, 2022

This commit doesn't change any logic. I simply moved the SQLConnector into a new sql module 🙂

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Attention: Patch coverage is 78.31325% with 54 lines in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (37595ec) to head (24464ae).
Report is 1039 commits behind head on main.

Files Patch % Lines
singer_sdk/connectors/sql.py 77.50% 37 Missing and 17 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   83.43%   83.46%   +0.03%     
==========================================
  Files          40       42       +2     
  Lines        3846     3853       +7     
  Branches      657      657              
==========================================
+ Hits         3209     3216       +7     
  Misses        472      472              
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

singer_sdk/streams/__init__.py Show resolved Hide resolved
singer_sdk/sql/__init__.py Outdated Show resolved Hide resolved
@kgpayne kgpayne merged commit 2bc7875 into main Oct 24, 2022
@kgpayne kgpayne deleted the kgpayne/issue1090 branch October 24, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Move SQLConnector into a separate module, for use by both SQLStream and SQLSink
3 participants