Follow-up from "Add sample GitHub CI file to tap Cookiecutter template"

[MeltyBot]

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/274

Originally created by @aaronsteers on 2021-11-18 21:13:37

---

IMPORTANT: Gitlab creates this issue by using the text of the first comment in the thread. In many cases the last comment is actually indicative of the next action. So, for proper context, you may need to click through to the individual threads.

The following discussions from !202 should be addressed:

• @pnadolny13 started a discussion: (+1 comment)

  @aaronsteers this is awesome! I know we have a [tox file](https://gitlab.com/meltano/sdk/-/blob/main/cookiecutter/tap-template/'Reference to deleted milestone 7'B%7Bcookiecutter.tap_id%7D%7D/tox.ini) as part of the cookiecutter, what about just executing that directly vs calling each test individually? I like the idea that if I can run tox locally then those tests should pass in CI but if theyre split out theres a risk of the CI file and tox file getting out of sync. I know theres some value in breaking each test up so its more DAG-like but it seems harder to maintain that way. Is there more value that we get from splitting then out that I missing?

• @edgarrmondragon started a discussion: (+2 comments)

  @aaronsteers Just occurred to me: if we're gonna add GitHub-specific files, wdyt about opt-in shipping a dependabot.yml like in tap-stackexchange. That would help with keeping the SDK and other dependencies up-to-date.

• @pnadolny13 started a discussion:

  I think isort might be missing from the toml file of the cookiecutter templates.

• @pnadolny13 started a discussion:

  I'm pretty new to mypy still but I had to include --ignore-missing-imports here in order to get it to pass. That might not be recommended but wanted to call it out.

• @pnadolny13 started a discussion: (+2 comments)

  Did we want to call poetry run tox -e pytest here instead of pytest directly?

[MeltyBot]

View 7 previous comments from the original issue on GitLab

[stale]

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

[edgarrmondragon]

Addressed by #1728