Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doublestar support in mount array #206

Closed
PaulRill00 opened this issue Jun 30, 2022 · 2 comments · Fixed by #209
Closed

Doublestar support in mount array #206

PaulRill00 opened this issue Jun 30, 2022 · 2 comments · Fixed by #209
Assignees
Labels
enhancement New feature or request v1.4.0 Issues for v1.4.0 release

Comments

@PaulRill00
Copy link

Is your feature request related to a problem? Please describe.
When working with mono-repo's caching dependencies might be tedious. So instead of mounting every subfolder and it's dependencies, allow for generic folder selection.

For example, if one has a folder structure like:

root
  package.json
  node_modules
  packages
    package1:
      package.json
      node_modules
      dist
    package2:
      package.json
      node_modules
      dist

Let's say you want to cache all node_modules and dist folders, without having to require all those folders in the mount array separately.

Describe the solution you'd like
Support generic folder mounting like:

mount:
  - "node_modules"
  - "packages/**/node_modules"
  - "packages/**/dist"

A dependency that might help solve the issue: https://github.com/bmatcuk/doublestar

Describe alternatives you've considered
You could also go with a regex alternative, but the one above seems more straight forward.

Additional context

  • None -
@bdebyl
Copy link
Contributor

bdebyl commented Jul 18, 2022

This looks like a fun quick feature, I'll look at adding it now for the next release

@bdebyl bdebyl added enhancement New feature or request v1.4.0 Issues for v1.4.0 release labels Jul 18, 2022
@bdebyl bdebyl self-assigned this Jul 18, 2022
@bdebyl bdebyl linked a pull request Jul 18, 2022 that will close this issue
11 tasks
@bdebyl
Copy link
Contributor

bdebyl commented Jul 19, 2022

Implemented as part of #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.4.0 Issues for v1.4.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants