Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As an user, when an unexisting email is input to login field, the user is redirected to a django error page.. #287

Closed
anacforcelli opened this issue Jan 29, 2020 · 4 comments
Closed

As an user, when an unexisting email is input to login field, the user is redirected to a django error page.. #287

anacforcelli opened this issue Jan 29, 2020 · 4 comments
Assignees
@hockpond
Labels
backend bug Something isn't working CMS user

Comments

@anacforcelli
Copy link
Contributor

anacforcelli commented Jan 29, 2020 •
edited
Loading

When a wrong email is input in login screen, there is a django error message. As dev.jandig.app has django on DEBUG=true, the error is shown as the following image:
Captura de tela de 2020-01-29 11-32-15
Django has to know that the email is wrong and show an user-friendly message telling that the username/email does not exist, instead of creating panic.
@anacforcelli anacforcelli added bug Something isn't working backend CMS user labels Jan 29, 2020
@anacforcelli
Copy link
Contributor Author

Great!

Though I also noticed the side doesn't say when you put an incorrect password, it just plain redirects you back to the login page

@hockpond hockpond added the XS label Jan 29, 2020
@hockpond
Copy link
Contributor

hockpond commented Jan 29, 2020 •
edited
Loading

Issue #288 added to handle this.

@vjpixel
Copy link
Member

vjpixel commented Jan 30, 2020

Can you please remove the bullet and change the text to "Username/email not found."

@vjpixel
Copy link
Member

vjpixel commented Jan 30, 2020

I've tested and it's working.

@vjpixel vjpixel closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hockpond hockpond

Labels
backend bug Something isn't working CMS user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vjpixel @hockpond @anacforcelli