Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UX oracle issues #156

Open
1 task done
Andrew718PLTS opened this issue Nov 19, 2024 · 4 comments
Open
1 task done

Improve the UX oracle issues #156

Andrew718PLTS opened this issue Nov 19, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Andrew718PLTS
Copy link
Contributor

Andrew718PLTS commented Nov 19, 2024

Description

The scope is to improve a UX for the "no valid median", "trading is suspended", "overflow x1y1", "can't create fixidity number larger than" error cases. Currently, we have only error notification toast with the "Unable to fetch swap out amount" message that is not so responsive - I guess we have to define a nice error toast with more responsive message that describe the certain case
(e.g: "An exchange price for currently unavailable - please try again later").

Acceptance Criteria

  • An error toast with a specified message appears when there are described errors
@philbow61 philbow61 changed the title Improve a UX for the "no valid median" case Improve the UX oracle issues Nov 21, 2024
@philbow61
Copy link
Contributor

@Andrew718PLTS
Copy link
Contributor Author

Andrew718PLTS commented Nov 22, 2024

image.png

There is another case where we need to improve a UX - when the trading is suspended for this reference rate.

Copy link
Contributor

@andrew.polovets @philip.raetsch i'm confused, can we close this ticket or not?

@Andrew718PLTS
Copy link
Contributor Author

Andrew718PLTS commented Jan 22, 2025

@chapati23 No, it's actually in progress (I should fix some things that were left @nvtaveras) - here is the PR.

In Zenhub, it looks like this only because I can't re-link my new PR that I mentioned here in the Zenhub board (Zenhub links once someone mentioned PR (e.g., fixes: #1) and can't link with the next mentions)
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants