Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct amazon-aws references from ScheduleUploadService #1088

Open
de-jcup opened this issue Feb 28, 2022 · 0 comments
Open

Remove direct amazon-aws references from ScheduleUploadService #1088

de-jcup opened this issue Feb 28, 2022 · 0 comments
Labels
build change management library

Comments

@de-jcup
Copy link
Member

de-jcup commented Feb 28, 2022 •
edited
Loading

Situation

While implementing #1085 it was necessary to expose the amazon aws dependency to scheduler because there is a direct usage of StringInputStream .

To avoid conflicts / side effects, the AWS dependency has been added as API dependency (but shouldn't because job storage shall hide this dependency)

Wanted

No direct usage of aws parts
Means
api project(':sechub-storage-s3-aws') inside sechub-shared-kernel/build.gradle shall be replaceable by implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build change management library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jeeppler @de-jcup