Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to parse EmploymentTypeEnum #3

Open
benzara-tahar opened this issue Oct 4, 2021 · 1 comment
Open

failed to parse EmploymentTypeEnum #3

benzara-tahar opened this issue Oct 4, 2021 · 1 comment

Comments

@benzara-tahar
Copy link

benzara-tahar commented Oct 4, 2021

After investigation , it seems the There is a missing enum value 'Terminated', can you add it ?

 /// <summary>
    /// Defines EmploymentTypeEnum
    /// </summary>
    [JsonConverter(typeof(StringEnumConverter))]
    public enum EmploymentTypeEnum
    {
        /// <summary>
        /// Enum FULLTIME for value: FULL_TIME
        /// </summary>
        [EnumMember(Value = "FULL_TIME")]
        FULLTIME = 1,

        /// <summary>
        /// Enum PARTTIME for value: PART_TIME
        /// </summary>
        [EnumMember(Value = "PART_TIME")]
        PARTTIME = 2,

        /// <summary>
        /// Enum INTERN for value: INTERN
        /// </summary>
        [EnumMember(Value = "INTERN")]
        INTERN = 3,

        /// <summary>
        /// Enum CONTRACTOR for value: CONTRACTOR
        /// </summary>
        [EnumMember(Value = "CONTRACTOR")]
        CONTRACTOR = 4,

        /// <summary> 
        /// Enum FREELANCE for value: FREELANCE
        /// </summary>
        [EnumMember(Value = "Terminated")]
        Terminated = 6 // <========================= THIS ONE

            

    }
@leewang0
Copy link
Contributor

We have an outstanding issue with the C# SDK. This particular language SDK does not adhere to our enum specifications for some accounts because the behavior of our API is:

The position's type of employment. Possible values include: FULL_TIME, PART_TIME, INTERN, CONTRACTOR, FREELANCE, or - in cases where there is no clear mapping - the original value passed through.

https://docs.merge.dev/hris/employments/#employments-object

I will try to return a default value with a string fallback property in this situation apologies for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants