Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File deletion #7

Open
balthazar opened this issue Dec 6, 2016 · 3 comments
Open

File deletion #7

balthazar opened this issue Dec 6, 2016 · 3 comments
Labels

Comments

@balthazar
Copy link
Collaborator

I hope you had a wonderful night, my friənd.

Might be out-of-scope of the project, but it's really a pain that we need to connect manually to the server if we want to delete a file.

Do you have any idea how we can solve this problem? A simple API could do the trick and it might be good to have.

@meriadec
Copy link
Owner

meriadec commented Dec 6, 2016

Well, dear fɿiend, it is not a so bad idea.

We can use the samus-sync server for that, with for example an environment variable pointing to the media folder, and accepting DELETE requests with file path in body.

Keep in mind that we don't want somebody to do (for example) the equivalent of rm -rf / (what dyou think?).

Client side, we can listen to backspace/delete keycode, and show some sort of "confirm modal" with blessed. It will also have a loading state during deletion.

What do you think?

@balthazar
Copy link
Collaborator Author

Nice yeah using the sync server part looks good!

Woah I absolutely didn't thought of a potential malicious rm, I guess I don't have your hacker spirit and talents.

I would prefer if we keep it simple, without any modal, and to prevent any """typo""" by using a combination of keys, like shift + backspace.

The 🏉 is in your camp.

@meriadec
Copy link
Owner

meriadec commented Dec 8, 2016

LGTM to use a keys combination instead of confirmation modal.

We should not forget to document this part, because deletion will work only if all our users have their own samus-sync server.
So I guess we will be forced to put this in .samusrc file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants