-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a HTTP link to a node description breaks the graph #467
Comments
I identified the carrets as a breaking factor in the live editor. You could use onclick event as per the documentation, but this doesn't provide for accessibility or SEO. And I see this has been root for a few other issues in the past: Since we can't escape them and text link also don't make for a great UI anyway, how about a way to put the link around the node?
or
If someone would point me toward the parts of the application that this solution would concern, I would happily help looking into it. |
I can reproduce the issue. I will take a look when I finish the other tasks on hand. |
Removing the quotes works on the live editor and for me locally. The Fiddle doesn't accept it, but that's probably a parsing mistake on their end. |
@samuei your hack fixes the immediate issue (the link is cliackable) but breaks the |
Hey all. I got links working. setup was |
As an aside, it seems that brackets (), encoded or not, break the flowchart. The only solution that worked for me was to escape them to unicode brackets. |
@wsw70 Could you please post a demo link using https://mermaidjs.github.io/mermaid-live-editor/? I don't quite understand the display:grid layout issue.
|
This works (by using same http/https protocol as the page itself):
|
This also works, (though sometimes need to respace when editing).
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not working 2022 May 1 on chrome Version 101.0.4951.41 (Official Build) (64-bit) |
Hi How to click the BTN and open another window? |
Even more specifically, it seems to be the double-quotes that crash the graph (not the Using single-quotes works for me in WebStorm. Here on GitHub, this:
renders like this: graph TD
B[an <b>important</b> <a href='http://google.com'>link</a>]
|
I would like, to the graph below (also available via a JSFiddle)
to add an actual link under
link
pointing tohttp://google.com
.I tried to modify the relevant node to
but this breaks (crashes) the graph. Specifically, I noticed that what is not accepted is the
href
element.Is it possible to add a link in a mermaid node?
Note: this report was initially asked as a question on SO but since other HTML tags are accepted it may rather be a bug.
The text was updated successfully, but these errors were encountered: