Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustls] simplify feature selection for rustls #21

Open
alexmaco opened this issue Jan 13, 2019 · 1 comment
Open

[rustls] simplify feature selection for rustls #21

alexmaco opened this issue Jan 13, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@alexmaco
Copy link

alexmaco commented Jan 13, 2019

I am opening this issue here, since has no option to open issues in the mesalock-linux/rustls repository.

Looking at the first commit on the rustls fork that adds feature flags (currently fed32702b8d7afaec1271ef8494188d4f8ae688b), I can see there are some areas that can be simplified, and the feature selection can be performed with less code and more clearly.

As an example, in impl SupportedGroups for NamedGroups, there can be a single supported method, and each item in the vector can be conditioned directly on the related feature, which would make it much easier to see exactly what NamedGroups are included for which feature.

I would like to open a PR with these simplifications, and I would like to ask how do you think this should be handled: would you apply commits on top of the mesalink branch of the rustls fork, or would you apply it directly op top of fed32702b8d7afaec1271ef8494188d4f8ae688b and rebase on top of that ?

@alexmaco alexmaco changed the title [rustls] simplify feature selction for rustls [rustls] simplify feature selection for rustls Jan 13, 2019
@ymjing ymjing added the enhancement New feature or request label Jan 17, 2019
@ymjing
Copy link
Contributor

ymjing commented Jan 17, 2019

It's OK to apply your commits on top of the mesalink branch. Looking forward to see you PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants