Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor does not call driver.stop() when killed #293

Closed
philwinder opened this issue Sep 9, 2015 · 1 comment
Closed

Executor does not call driver.stop() when killed #293

philwinder opened this issue Sep 9, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@philwinder
Copy link
Contributor

Add driver.stop to the killed and shutdown methods in the executor. If not, then the executor process will not exit and the docker image won't stop.

Both the killTasks and Shutdown methods in the executor should look like the following:

   LOGGER.info("Kill task: " + taskId.getValue());
   node.close();
   driver.sendStatusUpdate(taskStatus.finished());
   driver.stop();
@philwinder philwinder added the bug label Sep 9, 2015
@frankscholten frankscholten modified the milestone: Backlog Sep 9, 2015
@philwinder philwinder modified the milestones: 0.4.2, Backlog Sep 15, 2015
@philwinder philwinder self-assigned this Sep 16, 2015
@philwinder
Copy link
Contributor Author

Fixed in #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants