Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for healthcheck mechanism #303

Closed
5 tasks done
philwinder opened this issue Sep 15, 2015 · 1 comment
Closed
5 tasks done

Test coverage for healthcheck mechanism #303

philwinder opened this issue Sep 15, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@philwinder
Copy link
Contributor

We have sporadic evidence that the healthcheck timeout doesn't work properly.

Seems to be caused by a few subtle bugs.

  • Refactor ClusterMonitor to allow testing
  • Ensure that a new item isn't added to the cluster when re-starting with old tasks (addNewTaskToCluster)
  • Test that the correct number of items in is the cluster and is being monitored
  • Refactor cluster state out of ClusterMonitor. Has-A, not manages-a
  • Remove check for too many executors method. Should be in the scheduler

Normally, if you kill an executor, mesos detects it and sends a TASK_KILLED message straight away. Reconciliation works fine.

But sometimes, like when zookeeper has the wrong state (state says executor is running, but it is not running) it seems like the healthchecks get stuck somewhere. Suggest writing system test, based upon this, to see if we can replicate.

Possibly seen in:
#285

  • Tymofii's test cluster.
@philwinder
Copy link
Contributor Author

fixed in #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant