Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of using a variable is_initialized throw exceptions #147

Open
Rezenders opened this issue Dec 1, 2022 · 2 comments
Open

Instead of using a variable is_initialized throw exceptions #147

Rezenders opened this issue Dec 1, 2022 · 2 comments
Labels
ros2 ros2

Comments

@Rezenders
Copy link
Contributor

Instead of using a variable is_initialized throw exceptions.

@Rezenders Rezenders added the ros2 ros2 label Dec 1, 2022
@chcorbato
Copy link
Contributor

@Rezenders could you please add more information? E.g. link a relevant excerpt of code.

@Rezenders
Copy link
Contributor Author

The RosReasoner class has a variable called is_initialized that is only being used at the beginning of the RosReasoner main loop and in mros2_reasoner_node to check if there were any problems initializing the node.
For the first use, it is not really necessary since the loop is the last thing created in the __init__. For the second case, I think it would be better to guarantee that if there are any errors in the initialization process, an exception is thrown. I think the only point we should be worried about is reading the ontology files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 ros2
Projects
None yet
Development

No branches or pull requests

2 participants