Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reasoner.py and tomasys.py need to be refactored #158

Open
Rezenders opened this issue Dec 13, 2022 · 1 comment
Open

reasoner.py and tomasys.py need to be refactored #158

Rezenders opened this issue Dec 13, 2022 · 1 comment
Assignees
Labels
ARCH architecture design issue ros2 ros2

Comments

@Rezenders
Copy link
Contributor

Both reasoner.py and tomasys.py need to be refactored. It seems that some functions from tomasys.py should be in reasoner.py, and vice-versa. We need to define a clear separation of concerns, the line is a bit blurry.

For example, the obtain_best_function_design function from tomasys.py should be in reasoner.py since it is related to planning, which is something application specific.

@Rezenders Rezenders added ARCH architecture design issue ros2 ros2 labels Dec 13, 2022
@Rezenders Rezenders self-assigned this Dec 13, 2022
@chcorbato
Copy link
Contributor

This will probably be connected to #162 and #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARCH architecture design issue ros2 ros2
Projects
None yet
Development

No branches or pull requests

2 participants